Review Request 118194: Make it possible to select compiler at run-tume to deduce standard includes/defines
Sergey Kalinichev
kalinichev.so.0 at gmail.com
Sat May 31 13:02:43 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118194/
-----------------------------------------------------------
(Updated May 31, 2014, 5:02 p.m.)
Review request for KDevelop.
Changes
-------
Fixed the issues:
*Slightly generalized the code.
*Once again renamed classes hierarchy.
*Compiler names now localizable and pretty-printable.
*Compilers provide default path to executable.
...
Repository: kdevelop
Description
-------
To make it all work I had to turn IADM into global plugin, that way it can be used to retrieve includes/defines for files without project.
Also I made SettingsManager a shared library to ease access to it from different places.
Diffs (updated)
-----
languages/cpp/CMakeLists.txt 377f35e
languages/cpp/cpplanguagesupport.cpp 0f3bd4a
languages/cpp/cpputils.h c951bd3
languages/cpp/cpputils.cpp 380dd4e
languages/cpp/includepathcomputer.cpp 822b0bc
languages/cpp/msvcdefinehelper.cpp 9b131ed
languages/cpp/setuphelpers.h 012dcf4
languages/cpp/setuphelpers.cpp 57505fc
languages/cpp/setuphelpers_gcc_like.cpp b261589
languages/cpp/setuphelpers_msvc.cpp 5576c01
languages/cpp/tests/CMakeLists.txt d6eb67a
languages/cpp/tests/test_cppfiles.cpp 76486d0
languages/plugins/custom-definesandincludes/CMakeLists.txt be7d6e8
languages/plugins/custom-definesandincludes/compilerprovider/CMakeLists.txt PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.h PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/compilerprovider.cpp PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.h PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/gcclikecompiler.cpp PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/icompiler.h PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/icompilerprovider.h PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/kdevcompilerprovider.desktop.cmake PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.h PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/msvccompiler.cpp PRE-CREATION
languages/plugins/custom-definesandincludes/compilerprovider/msvcdefinehelper.cpp PRE-CREATION
languages/plugins/custom-definesandincludes/definesandincludesexport.h PRE-CREATION
languages/plugins/custom-definesandincludes/definesandincludesmanager.h 12a7763
languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp bdce956
languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt ffde4f1
languages/plugins/custom-definesandincludes/kcm_widget/customdefinesandincludes.kcfg 3b49940
languages/plugins/custom-definesandincludes/kcm_widget/customdefinesandincludes.kcfgc 720af41
languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.ui a70d751
languages/plugins/custom-definesandincludes/kcm_widget/kcm_customdefinesandincludes.cpp 75f5063
languages/plugins/custom-definesandincludes/kcm_widget/kcm_kdevcustomdefinesandincludes.desktop ef63c57
languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h 17ebfd7
languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp bae2555
languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 0ab656c
languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.desktop.cmake ad08867
languages/plugins/custom-definesandincludes/settingsmanager.h 9ae23d6
languages/plugins/custom-definesandincludes/settingsmanager.cpp dc7aa3e
languages/plugins/custom-definesandincludes/tests/definesandincludestest.cpp a39c196
projectmanagers/custom-buildsystem/tests/projects/builddirproject/.kdev4/builddirproject.kdev4 33c8568
projectmanagers/custom-buildsystem/tests/projects/multipathproject/.kdev4/multipathproject.kdev4 fd14aca
projectmanagers/custom-buildsystem/tests/projects/simpleproject/.kdev4/simpleproject.kdev4 2c4bac5
Diff: https://git.reviewboard.kde.org/r/118194/diff/
Testing
-------
All tests pass (except cppspecialcompletion, which doesn't work for me anyway).
Also I've tested it with 3 opened projects in one session, works fine for me.
File Attachments
----------------
kdevplatform.diff
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/23/3a7228b1-c22a-4f00-9ab7-3f4d12fc1107__kdevplatform.diff
selectCompiler_image.png
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/23/4f199bb9-f4d0-4525-98f5-78e3d3e9829f__selectCompiler_image.png
Thanks,
Sergey Kalinichev
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140531/e632f455/attachment-0001.html>
More information about the KDevelop-devel
mailing list