Review Request 118420: Added an 'on-progress' status icon to the testview to indicate that a test is running.

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118420/#review58801
-----------------------------------------------------------



interfaces/itestcontroller.h
<https://git.reviewboard.kde.org/r/118420/#comment40902>

    Starting is not really a result type.



interfaces/itestcontroller.h
<https://git.reviewboard.kde.org/r/118420/#comment40903>

    This shouldn't pass a TestResult argument, there's no result when we're starting.



plugins/testview/testview.cpp
<https://git.reviewboard.kde.org/r/118420/#comment40904>

    using updateTestSuite is a bit of a workaround here, because it required us to re-define what a TestResult is.
    
    We probably want a new testSuiteStarted or similar.


- Aleix Pol Gonzalez


On May 30, 2014, 12:46 p.m., Pepe Osca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118420/
> -----------------------------------------------------------
> 
> (Updated May 30, 2014, 12:46 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> A new 'on-progress' state and icon have been added to the testview to indicate that a test is running.
> 
> 
> Diffs
> -----
> 
>   interfaces/itestcontroller.h 8350dfc 
>   plugins/testview/testview.cpp 5f7addf 
>   shell/testcontroller.h 9d8783e 
>   shell/testcontroller.cpp 857f88a 
>   shell/tests/testcontrollertest.cpp ce6b52b 
> 
> Diff: https://git.reviewboard.kde.org/r/118420/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pepe Osca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140530/b336dc2d/attachment.html>