Review Request 118401: Handle QML modules and import statements

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118401/#review58749
-----------------------------------------------------------

Ship it!


>From what I understand it looks good. Thanks!

- Sven Brauch


On May 29, 2014, 4:02 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118401/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 4:02 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch adds support for QML modules, and completes the support of import statements. "Module" declarations are translated to a namespace, and import statements not only import a TopDUContext, but also create a namespace alias that imports the namespace of the module. This way, the declarations of a module are visible in the global scope of the importing file, and yet KDevelop is able to say that Button comes from QtQuick.Controls.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.h d20f275 
>   duchain/declarationbuilder.cpp 46d0deb 
>   duchain/parsesession.h 591c85a 
>   duchain/parsesession.cpp 6edc145 
>   tests/files/plugins.qml cd201bb 
> 
> Diff: https://git.reviewboard.kde.org/r/118401/diff/
> 
> 
> Testing
> -------
> 
> The unit tests pass, UseBuilder is able to see that Button is an use of QtQuick.Controls::Button, and the code-completion popup can list all the attributes available in a QML component.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140529/3a6f17ea/attachment-0001.html>