Review Request 118393: Replace every use of openDeclaration by openDefinition
Denis Steckelmacher
steckdenis at yahoo.fr
Thu May 29 13:59:34 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118393/
-----------------------------------------------------------
(Updated May 29, 2014, 1:59 p.m.)
Status
------
This change has been discarded.
Review request for KDevelop.
Repository: kdev-qmljs
Description
-------
Javascript does not have a concept of declarations and definitions (or the plugin currently does not support any construct that behaves like a declaration). This patch proposes to replace every use of openDeclaration by openDefinition, so that every declaration is also a definition. This does not change anything feature-wise but might be a bit more "exact" regarding the semantics of Javascript.
Diffs
-----
duchain/declarationbuilder.cpp 315beef
Diff: https://git.reviewboard.kde.org/r/118393/diff/
Testing
-------
All the unit tests continue to pass.
Thanks,
Denis Steckelmacher
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140529/c8850085/attachment-0001.html>
More information about the KDevelop-devel
mailing list