Review Request 118393: Replace every use of openDeclaration by openDefinition

[Denis Steckelmacher]

> On May 29, 2014, 12:24 p.m., Sven Brauch wrote:
> > Hm, hm, not sure about this. Other languages (Python, PHP, Ruby) use openDeclaration as well and it works fine. Is there an actual reason to change it? Otherwise I would not do it.

No, there is no reason. If you say that the other languages use openDeclaration, then I will follow them.


- Denis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118393/#review58708
-----------------------------------------------------------


On May 29, 2014, 11:42 a.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118393/
> -----------------------------------------------------------
> 
> (Updated May 29, 2014, 11:42 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> Javascript does not have a concept of declarations and definitions (or the plugin currently does not support any construct that behaves like a declaration). This patch proposes to replace every use of openDeclaration by openDefinition, so that every declaration is also a definition. This does not change anything feature-wise but might be a bit more "exact" regarding the semantics of Javascript.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp 315beef 
> 
> Diff: https://git.reviewboard.kde.org/r/118393/diff/
> 
> 
> Testing
> -------
> 
> All the unit tests continue to pass.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140529/cae44c57/attachment.html>