Review Request 118191: Add "batch edit" mode to Defines and Includes GUI

[Sergey Kalinichev]

> On May 26, 2014, 7:17 p.m., Milian Wolff wrote:
> > languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp, line 223
> > <https://git.reviewboard.kde.org/r/118191/diff/2/?file=273965#file273965line223>
> >
> >     is this not equivalent to:
> >     
> >     ^([^=]+)=?(.*)$
> >     
> >     note that this reduces the list of capture groups as well. But anyways, not worth haggling about.

Tried it. It doesn't work for e,g,: a = b 
In that case the = is captured too...
So I'm leaving it as is.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118191/#review58491
-----------------------------------------------------------


On May 21, 2014, 9:36 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118191/
> -----------------------------------------------------------
> 
> (Updated May 21, 2014, 9:36 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Now it's possible to modify many include directories and defined macros at the same time.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt 0d8c830 
>   languages/plugins/custom-definesandincludes/kcm_widget/batchedit.ui PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp 4df3236 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp 31feca6 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.ui 5542ef4 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h 4198d65 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 1456217 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 4e512a9 
> 
> Diff: https://git.reviewboard.kde.org/r/118191/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/d70d3754-38e4-4f44-9c9a-566bb36f84af__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/21/aa6b8155-6487-4892-b47d-396ee6adb4a8__after.png
> batch edit.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/21/e5a47679-8bc4-477f-b02e-07c641b7978d__batch_edit.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140527/f95c781a/attachment.html>