Review Request 118191: Add "batch edit" mode to Defines and Includes GUI

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118191/#review58217
-----------------------------------------------------------



languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp
<https://git.reviewboard.kde.org/r/118191/#comment40471>

    const index = qMax(ui->..., 0);



languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp
<https://git.reviewboard.kde.org/r/118191/#comment40472>

    remove whitespace in front of comma



languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp
<https://git.reviewboard.kde.org/r/118191/#comment40473>

    having the first capture able to be empty does not make sense, does it? Also, you don't need to capture the =
    
    so I'd rewrite the pattern like this to make it easier to understand
    
    ^([^=]+)=(.*)$


- Milian Wolff


On May 18, 2014, 10:43 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118191/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 10:43 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Now it's possible to modify many include directories and defined macros at the same time.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 4e512a9 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 1456217 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h 4198d65 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.ui 5542ef4 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp 31feca6 
>   languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp 4df3236 
>   languages/plugins/custom-definesandincludes/kcm_widget/batchedit.ui PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt 0d8c830 
> 
> Diff: https://git.reviewboard.kde.org/r/118191/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/d70d3754-38e4-4f44-9c9a-566bb36f84af__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/af3366d0-23fc-43e3-96e7-f449ac7f987d__after.png
> batch edit.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/53393f2f-4d77-479e-ac9d-0d5383a37247__batch_edit.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140521/270db657/attachment.html>