Review Request 118191: Add "batch edit" mode to Defines and Includes GUI

[Milian Wolff]

> On May 18, 2014, 4:21 p.m., Andreas Pakulat wrote:
> > I'm wondering: Why not make this the standard way to edit the entries? Besides completion when doing inline editing I'm not sure there's any important reason to keep a listview instead of allowing the editing through a text editor. The completion could be added to the editor quite easily too.
> > 
> > The only downside could be that its easier to break the entries by accidentally inserting newlines in the middle of a path. However that causes incorrectly parsed source code in the worst case and can be easily fixed once the user notices it. (there could be a warning if there are non-existing paths too).
> > 
> > The buttons would also be removable then, one just needs the browse button for easy access to a file dialog which just adds a new line after the current one.
> 
> Sergey Kalinichev wrote:
>     >Why not make this the standard way to edit the entries?
>     
>     You mean remove all that model/view stuff and use a text editor instead? 
>     Well, initially I wanted to do it that way too, but then something stopped me from doing it (it has something to do with editing many includes/defines from different providers, can't recall exactly what it was...)
>     
>     Also QtCreator uses the same approach for editing "Build Environment" variables.
>     
>     So I suggest keeping that functionality here for the time being, and if it doesn't come in handy during implementation of editing many includes/defines from different providers at the same time I'll remove it then.

I also would like to keep the list I think. It makes it simpler to show the user we parse stuff as he wants it.

I'd just add a proper window title to the batch-edit dialog.

Another issue I see is that the batch-edit button is misplaced, I think. It should be next to the other buttons in the line with "A new include path...". Up there the context is wrong, imo. You are batch-editing includes or defines after all so it depends on the tab selection below - no?


- Milian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118191/#review58120
-----------------------------------------------------------


On May 18, 2014, 10:43 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118191/
> -----------------------------------------------------------
> 
> (Updated May 18, 2014, 10:43 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Now it's possible to modify many include directories and defined macros at the same time.
> 
> 
> Diffs
> -----
> 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.ui 4e512a9 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.cpp 1456217 
>   languages/plugins/custom-definesandincludes/kcm_widget/projectpathswidget.h 4198d65 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.ui 5542ef4 
>   languages/plugins/custom-definesandincludes/kcm_widget/includeswidget.cpp 31feca6 
>   languages/plugins/custom-definesandincludes/kcm_widget/defineswidget.cpp 4df3236 
>   languages/plugins/custom-definesandincludes/kcm_widget/batchedit.ui PRE-CREATION 
>   languages/plugins/custom-definesandincludes/kcm_widget/CMakeLists.txt 0d8c830 
> 
> Diff: https://git.reviewboard.kde.org/r/118191/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/d70d3754-38e4-4f44-9c9a-566bb36f84af__before.png
> after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/af3366d0-23fc-43e3-96e7-f449ac7f987d__after.png
> batch edit.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/18/53393f2f-4d77-479e-ac9d-0d5383a37247__batch_edit.png
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140521/883aca62/attachment-0001.html>