Review Request 118185: Fix session name display in session runner
Aleix Pol Gonzalez
aleixpol at kde.org
Sun May 18 19:26:35 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118185/#review58123
-----------------------------------------------------------
Ship it!
I think the patch makes sense, although I can't try it anymore. Weird thing is that nobody has noticed it was wrong...
- Aleix Pol Gonzalez
On May 17, 2014, 9:55 p.m., Lasse Liehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118185/
> -----------------------------------------------------------
>
> (Updated May 17, 2014, 9:55 p.m.)
>
>
> Review request for KDevelop.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Session name was shown twice because SessionPrettyContents already contains it. This caused the runner to display names like: "kdevelop: kdevelop: kdevelop, kdevplatform" where kdevelop was the session name and kdevelop and kdevplatform were the projects open in that session.
>
> I'm unsure if this is a good way to fix this because I don't know what the semantics of SessionPrettyContents should be.
>
>
> Diffs
> -----
>
> app/plasma/runner/kdevelopsessions.cpp cccd3f1
>
> Diff: https://git.reviewboard.kde.org/r/118185/diff/
>
>
> Testing
> -------
>
> It works.
>
>
> Thanks,
>
> Lasse Liehu
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140518/8a9631e3/attachment.html>
More information about the KDevelop-devel
mailing list