Review Request 116978: Add a template specific project name regex

Milian Wolff mail at milianw.de
Wed May 14 19:35:22 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116978/#review57941
-----------------------------------------------------------

Ship it!


Ship It!

- Milian Wolff


On May 14, 2014, 6:11 p.m., Simon Wächter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116978/
> -----------------------------------------------------------
> 
> (Updated May 14, 2014, 6:11 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Review 1174707 allows a project template to use a more specific regex for their project name validation.
> 
> This patch adds a template specific regex for all C++ templates that KDevelop provides. A C++ project can start now with a-Z or a '_'. After the first character, a-Z, 0-9 and '_' can be used.
> 
> 
> Diffs
> -----
> 
>   app_templates/cpp/CMake/cmake_plaincpp/cmake_plaincpp.kdevtemplate e55ea45 
>   app_templates/cpp/CMake/cmake_qt4core/cmake_qt4core.kdevtemplate f5b5208 
>   app_templates/cpp/CMake/cmake_qt4core_qtest/cmake_qt4core_qtest.kdevtemplate eb377eb 
>   app_templates/cpp/CMake/cmake_qt4gui/cmake_qt4gui.kdevtemplate 11a32aa 
> 
> Diff: https://git.reviewboard.kde.org/r/116978/diff/
> 
> 
> Testing
> -------
> 
> Patch was tested with several different project templates - some contain the additional config value, some not. Test result is ok.
> 
> 
> Thanks,
> 
> Simon Wächter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140514/fd792335/attachment.html>


More information about the KDevelop-devel mailing list