Review Request 118072: Split Utils::getQMLAttribute

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118072/#review57680
-----------------------------------------------------------

Ship it!


If you are confident with it, feel free to submit things (such as this code shifting) without review requests ;)

- Sven Brauch


On May 10, 2014, 2:03 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118072/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 2:03 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch splits Utils::getQMLAttribute into two functions : getQMLAttribute (that returns an AST node) and getQMLAttributeValue (that returns a string and a source location). This is needed because DeclarationBuilder may sometimes need to get a QML attribute's expression node in order to iterate over it, for instance to get all the keys of an array. In this case, a string is not enough.
> 
> The patchs does not change more than that but is fairly long because I had to change the indentation of some pieces of code.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp 13e366d 
>   duchain/helper.h 957fb17 
>   duchain/helper.cpp 675a0c5 
> 
> Diff: https://git.reviewboard.kde.org/r/118072/diff/
> 
> 
> Testing
> -------
> 
> The whole testsuite of the plugin still passes with this patch applied.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140510/a093fbb4/attachment.html>