Review Request 117407: Add a project name validation in the project creation dialog

[Simon Wächter]

> On May 5, 2014, 10:06 a.m., Kevin Funk wrote:
> > Bump. What's the state here? I have the feeling this RR can be abandoned(?)
> 
> Sven Brauch wrote:
>     I still think it should be submitted instead of leaving this broken for three more releases.
>     From what I understood Simon is still investigating a better option ...?
> 
> Simon Wächter wrote:
>     From my point of view there are 3 good options:
>     
>     1.) Provide the project name restriction via regex by the template itself. This needs more work (also in the KAppTemplate project), but is future-proof and allows adding a new category without a change in KDevelop/KDevPlatform/KAppTemplate project.
>     2.) Set a project name restriction for the template categories, for example C++, Python etc, so we don't have to change the templates. But this needs a change if someone adds a new category - so not the best way.
>     3.) Simplify the project name as Phil Schaf mentioned it. But with what criterias do we simplify ? Language ? In the end we have to hardcode something - or end in the first version: Just add a general regex.
>     
>     I think that option 1 is the most solid and future proof solution. But it needs some work and the ok to add a new variable with the regex in every template. If there is an ok from the KAppTemplate and KDevelop site I can start implementing it.
>
> 
> Aleix Pol Gonzalez wrote:
>     I think we can go with 1), we can fallback to a restrictive default as discussed earlier, so that we don't need to rush and patch all templates.
> 
> Sven Brauch wrote:
>     +1

Ok, in this case I'll start with it


- Simon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117407/#review57291
-----------------------------------------------------------


On April 6, 2014, 9:06 p.m., Simon Wächter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117407/
> -----------------------------------------------------------
> 
> (Updated April 6, 2014, 9:06 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> This patch adds a regex validation for the project name in the project creation dialog. The project name has to start with a/A-z/Z and can contain a/A-z/Z, 0-9 and the _ character.
> 
> The idea of this patch is to make an invalid class name in a new project impossible, for example "42fooclass" or "_barclass".
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/projectselectionpage.cpp 6270869 
> 
> Diff: https://git.reviewboard.kde.org/r/117407/diff/
> 
> 
> Testing
> -------
> 
> Tested with several different project strings
> 
> 
> Thanks,
> 
> Simon Wächter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140508/0739a38d/attachment.html>