Review Request 118031: Reparse the project when includes/defines change (kdevplatform)

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118031/#review57480
-----------------------------------------------------------



language/backgroundparser/parseprojectjob.cpp
<https://git.reviewboard.kde.org/r/118031/#comment39995>

    add newline before {



shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/118031/#comment39990>

    QHash



shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/118031/#comment39993>

    this is odd, I'd expect this to be wrong usage. if at all, do a Q_ASSERT(project) but even that, I'd leave out as its an obvious mistake imo.
    
    why did you add this check?



shell/projectcontroller.cpp
<https://git.reviewboard.kde.org/r/118031/#comment39994>

    rewrite this block as:
    
    if (auto job = d->m_parseJobs.value(project)) {
      job->kill();
    }


- Milian Wolff


On May 7, 2014, 9:15 a.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118031/
> -----------------------------------------------------------
> 
> (Updated May 7, 2014, 9:15 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Initially I wanted to use ParsingEnvironmentFile approach, but it seems like clang-plugin dosn't use all of it's functionallity (i.e it adds only the current file to the list of dependencies), also it's unclear to me how to handle defines in that approach. So instead I've decided to completly reparse the project.
> 
> 
> Diffs
> -----
> 
>   interfaces/iprojectcontroller.h 7ede76fc 
>   language/backgroundparser/parseprojectjob.h 8a6098b 
>   language/backgroundparser/parseprojectjob.cpp b0adc5e 
>   shell/projectcontroller.h 8c24376 
>   shell/projectcontroller.cpp 5257f49 
> 
> Diff: https://git.reviewboard.kde.org/r/118031/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140507/32215ddc/attachment.html>