Review Request 118023: Try to import pyx-files when searching for modules

[Sven Brauch]

> On May 6, 2014, 4:15 p.m., Sven Brauch wrote:
> > duchain/contextbuilder.cpp, line 369
> > <https://git.reviewboard.kde.org/r/118023/diff/1/?file=271834#file271834line369>
> >
> >     I would be happier if this would only change when the current file is a pyx file. Otherwise you can import pyx files from py files, and other funny stuff; also, it's slower.
> >     
> >     Plus, this string list could be static ;)
> 
> Gregor Vollmer wrote:
>     Actually, I am importing pyx files from py files! How else would you access these modules...?
>     
>     But you're right with static delclaration ;-)

Oh, hm, right. That's now what happens in the background but from KDevelop's perspecive that's the way to represent it, I guess.
Not that great,  because it requires a lot more stat calls which makes things slower, but I guess that's how it is. At least don't check the dir twice, then.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118023/#review57428
-----------------------------------------------------------


On May 6, 2014, 4:12 p.m., Gregor Vollmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118023/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 4:12 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Try to import pyx-files when searching for modules
>     
>     Cython modules where ignored by the import finder, thus
>     the files can be parsed but the information cannot be used
>     from other modules.
>     
>     First, .py files are tried, then .pyx files.
> 
> 
> Diffs
> -----
> 
>   duchain/contextbuilder.cpp 06cefd411089517daf80a3bd320960b34a07bb45 
> 
> Diff: https://git.reviewboard.kde.org/r/118023/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Vollmer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140506/69c7251f/attachment-0001.html>