Review Request 118023: Try to import pyx-files when searching for modules

Sven Brauch svenbrauch at googlemail.com
Tue May 6 16:15:34 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118023/#review57428
-----------------------------------------------------------



duchain/contextbuilder.cpp
<https://git.reviewboard.kde.org/r/118023/#comment39955>

    I would be happier if this would only change when the current file is a pyx file. Otherwise you can import pyx files from py files, and other funny stuff; also, it's slower.
    
    Plus, this string list could be static ;)


- Sven Brauch


On May 6, 2014, 4:12 p.m., Gregor Vollmer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118023/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 4:12 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Try to import pyx-files when searching for modules
>     
>     Cython modules where ignored by the import finder, thus
>     the files can be parsed but the information cannot be used
>     from other modules.
>     
>     First, .py files are tried, then .pyx files.
> 
> 
> Diffs
> -----
> 
>   duchain/contextbuilder.cpp 06cefd411089517daf80a3bd320960b34a07bb45 
> 
> Diff: https://git.reviewboard.kde.org/r/118023/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Vollmer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140506/fbbd296b/attachment.html>


More information about the KDevelop-devel mailing list