Review Request 117938: Support for default include path and definitions on CLang compiler.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117938/#review57168
-----------------------------------------------------------



languages/cpp/setuphelpers.cpp
<https://git.reviewboard.kde.org/r/117938/#comment39852>

    Drop



languages/cpp/setuphelpers.cpp
<https://git.reviewboard.kde.org/r/117938/#comment39853>

    Rather:
    
    QStringList includePaths = gccSetupStandardIncludePaths();
    if (!includePaths) {
        includePaths = clangSetupStandardIncludePaths();
    }



languages/cpp/setuphelpers.cpp
<https://git.reviewboard.kde.org/r/117938/#comment39854>

    Analogue to above


Now, instead of implementing your own clangSetupStandardIncludePaths please just parameterize gccSetupStandardIncludePaths and rename that to something along 'gccLikeSetupStandardIncludePaths'. That output format won't change in the near future, you don't need to fear that. It should parse the Clang output just fine.

We also might want to add support for ICC (Intel Compiler) and/or others, too, at some point. Most of them are interoperable with GCC's interface and offer the same command-line options.

- Kevin Funk


On May 2, 2014, 7:38 p.m., Luis Felipe Dominguez Vega wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117938/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 7:38 p.m.)
> 
> 
> Review request for KDevelop and Luis Felipe Dominguez Vega.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> When I compile Kdevelop using only in my Debian Testing Clang 3.4, the defaults include paths is not recognized. In the code I will see that the functions are only for GCC and MSVC, with this patch now with Clang are recognized both, the include paths, and standard definitions.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 5add7c0 
>   languages/cpp/setuphelpers.cpp 7481256 
>   languages/cpp/setuphelpers_clang.cpp PRE-CREATION 
>   languages/cpp/tests/CMakeLists.txt dcf5087 
> 
> Diff: https://git.reviewboard.kde.org/r/117938/diff/
> 
> 
> Testing
> -------
> 
> Tested in my own PC, Debian Testing 64 bits, Clang 3.4, Kernel "Linux 3.13.10lfdominguez #1 SMP PREEMPT Sat Apr 26 17:56:25 UTC 2014 x86_64 GNU/Linux"
> 
> 
> Thanks,
> 
> Luis Felipe Dominguez Vega
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/1d409711/attachment.html>