Review Request 117922: Preliminary implementation of adjust signature helper

[David Stevens]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117922/
-----------------------------------------------------------

(Updated May 2, 2014, 7:56 p.m.)


Review request for KDevelop.


Changes
-------

Addressed some of the comments. The signature assistant lifespan as been increased, and it now handles default arguments. I haven't done unit tests yet, but I'm working on them. I'd like to get this commited sooner rather than later, though.


Repository: kdev-clang


Description
-------

This is a preliminary implementation of the adjust signature helper. It works fairly well under normal usage, but it runs into problems if the user starts trying to use it at a high frequency. There are some rather fundamental issues both due to the different information organization (files vs translation units) and due to the discrepencies between what KDevelop has in the text editor and what clang has in the translation units. Hopefully I can get some feedback on the implementation.


Diffs (updated)
-----

  clangsupport.h 1316f88 
  clangsupport.cpp 5e3f464 
  codecompletion/completionhelper.cpp dfaf6b3 
  codegen/CMakeLists.txt 0b913bd 
  codegen/clangsignatureassistant.h PRE-CREATION 
  codegen/clangsignatureassistant.cpp PRE-CREATION 
  codegen/codeassistant.h PRE-CREATION 
  codegen/codeassistant.cpp PRE-CREATION 
  duchain/clangtypes.h c7293a9 
  duchain/clangtypes.cpp 11760c8 
  tests/CMakeLists.txt c2fd36d 
  util/clangutils.h 3516821 
  util/clangutils.cpp a74017c 

Diff: https://git.reviewboard.kde.org/r/117922/diff/


Testing
-------

Manual. Any unit tests would be deeply tied into the GUI, so I'm not sure how to go about writing those. The old c++ plugin unfortunately doesn't have any tests to work off of.


Thanks,

David Stevens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/35ac615a/attachment.html>