Review Request 117938: Support for default include path and definitions on CLang compiler.

[Luis Felipe Dominguez Vega]

> On May 2, 2014, 10:10 a.m., Milian Wolff wrote:
> > languages/cpp/tests/CMakeLists.txt, line 18
> > <https://git.reviewboard.kde.org/r/117938/diff/1/?file=270723#file270723line18>
> >
> >     the patch is missing this file
> 
> Luis Felipe Dominguez Vega wrote:
>     The file is in attachments, because the diff only is for the files tracked with git, so, this file is new and don't appear into de .diff. Thanks....
> 
> Sergey Kalinichev wrote:
>     So what? git add /path/to/file ; git diff --staged. Or something like that...
>     
>     Anaway why don't you generalize setuphelpers_gcc.cpp instead? Seems like there're not so many changes required to make it work with clang. Actually changing gcc to clang should suffice.

Generalizing the setuphelpers_gcc.cpp do that if in the future the Clang people change any thing referent to this, we need change all the archive or worse, create the file, so in my point of view is better put into other file.


- Luis Felipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117938/#review57106
-----------------------------------------------------------


On May 2, 2014, 6:45 p.m., Luis Felipe Dominguez Vega wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117938/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 6:45 p.m.)
> 
> 
> Review request for KDevelop and Luis Felipe Dominguez Vega.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> When I compile Kdevelop using only in my Debian Testing Clang 3.4, the defaults include paths is not recognized. In the code I will see that the functions are only for GCC and MSVC, with this patch now with Clang are recognized both, the include paths, and standard definitions.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 5add7c0 
>   languages/cpp/setuphelpers.cpp 7481256 
>   languages/cpp/setuphelpers_clang.cpp PRE-CREATION 
>   languages/cpp/tests/CMakeLists.txt dcf5087 
> 
> Diff: https://git.reviewboard.kde.org/r/117938/diff/
> 
> 
> Testing
> -------
> 
> Tested in my own PC, Debian Testing 64 bits, Clang 3.4, Kernel "Linux 3.13.10lfdominguez #1 SMP PREEMPT Sat Apr 26 17:56:25 UTC 2014 x86_64 GNU/Linux"
> 
> 
> File Attachments
> ----------------
> 
> The new setuphelpers for Clang
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/02/77eba2af-7c77-4ebd-9d74-a568278d1912__setuphelpers_clang.cpp
> 
> 
> Thanks,
> 
> Luis Felipe Dominguez Vega
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/abb821fc/attachment.html>