Review Request 117938: Support for default include path and definitions on CLang compiler.

[Luis Felipe Dominguez Vega]

> On May 2, 2014, 4:57 p.m., Kevin Funk wrote:
> > Hm. There are two general problems with this patch:
> > - I suspect that 'setuphelpers_clang.cpp' is copy-pasted from setuphelpers_gcc.cpp -- You should rather generalize setuphelpers_gcc.cpp to support both
> > - Even worse: Right now selecting between Clang and GCC is compile-time(!) option. -- You should rather check that at runtime. (i.e. if 'gcc' was not found, use 'clang' to retrieve the default include paths)
> > 
> > Even it it's just a temporary solution -- it's wrong to make that depend on the compiler used to build the IDE.

Well, copy-pasted is'nt because if you see, in this file I'm using Regex, so is not the same. In Clang, many of the commands are the same than the GCC compiling, for compatibility, but.... in the future i don't known if the people of Clang maintain this, so in generic way speaking, is best (as I see) maintain the code separated.
I don't use the runtime option because i simple add the support for clang in compiling time, only this, is the same think that is does with the MSVC. In the runtime version is depend of the compiler use in the project and the GSOC work by Sergey are working in that...


- Luis Felipe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117938/#review57155
-----------------------------------------------------------


On May 2, 2014, 6:45 p.m., Luis Felipe Dominguez Vega wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117938/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 6:45 p.m.)
> 
> 
> Review request for KDevelop and Luis Felipe Dominguez Vega.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> When I compile Kdevelop using only in my Debian Testing Clang 3.4, the defaults include paths is not recognized. In the code I will see that the functions are only for GCC and MSVC, with this patch now with Clang are recognized both, the include paths, and standard definitions.
> 
> 
> Diffs
> -----
> 
>   languages/cpp/CMakeLists.txt 5add7c0 
>   languages/cpp/setuphelpers.cpp 7481256 
>   languages/cpp/setuphelpers_clang.cpp PRE-CREATION 
>   languages/cpp/tests/CMakeLists.txt dcf5087 
> 
> Diff: https://git.reviewboard.kde.org/r/117938/diff/
> 
> 
> Testing
> -------
> 
> Tested in my own PC, Debian Testing 64 bits, Clang 3.4, Kernel "Linux 3.13.10lfdominguez #1 SMP PREEMPT Sat Apr 26 17:56:25 UTC 2014 x86_64 GNU/Linux"
> 
> 
> File Attachments
> ----------------
> 
> The new setuphelpers for Clang
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/05/02/77eba2af-7c77-4ebd-9d74-a568278d1912__setuphelpers_clang.cpp
> 
> 
> Thanks,
> 
> Luis Felipe Dominguez Vega
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/4b0ef65c/attachment.html>