Review Request 117835: Now IDM (Includes/Defines manager) provides all types of includes/defines, not just user-specified. (kdevplatform)

[Sergey Kalinichev]

> On May 2, 2014, 5:19 p.m., Milian Wolff wrote:
> > project/interfaces/ibuildsystemmanager.h, line 66
> > <https://git.reviewboard.kde.org/r/117835/diff/2/?file=270613#file270613line66>
> >
> >     because it is an interface

I don't get it. I've just went through KDevelop's code base and it seems like pure interfaces are very rare, most provide default implementation for some functions, I see no reason why IBSM can't do it that way too, especially when we already have 2 plugins that don't use that functionality.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117835/#review57131
-----------------------------------------------------------


On May 1, 2014, 3:20 p.m., Sergey Kalinichev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117835/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 3:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The changes include extending IDM interface and removing i/d notion from IBuildSystemManager interface.
> 
> 
> Diffs
> -----
> 
>   language/interfaces/idefinesandincludesmanager.h ab42444 
>   project/interfaces/ibuildsystemmanager.h 241b696 
>   project/interfaces/ibuildsystemmanager.cpp 74af0e7 
> 
> Diff: https://git.reviewboard.kde.org/r/117835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Kalinichev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/82bebd3a/attachment.html>