Review Request 117836: Now IDM (Includes/Defines manager) provides all types of includes/defines, not just user-specified. (kdevelop)

[Sergey Kalinichev]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117836/
-----------------------------------------------------------

(Updated May 2, 2014, 4:53 p.m.)


Review request for KDevelop.


Changes
-------

Ok, let's make it the other way around: UserDefined have the highest priority and overwrite values of all other types of defines.


Repository: kdevelop


Description
-------

  Currently to retrieve i/d we use IBuildSystemManager, that's imo very strange, as I don't see any reason why e.g. builder() method and includes() should be in one interface? Language plugins obviously don't use the former... 
  Also not all project manager use i/d functionality (e.g. Custom build system doesn't).
  Finally, with that path applied it becomes simpler to retrieve i/d as now all information is accessible from one place.


Diffs (updated)
-----

  languages/cpp/includepathcomputer.cpp c3bc05a 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.h bd560eb 
  languages/plugins/custom-definesandincludes/definesandincludesmanager.cpp d1723d3 
  languages/plugins/custom-definesandincludes/kdevdefinesandincludesmanager.desktop.cmake 65b933f 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.h 0798602 
  projectmanagers/custom-buildsystem/custombuildsystemplugin.cpp db194a4 
  projectmanagers/custommake/custommakemanager.h 6946e62 
  projectmanagers/custommake/custommakemanager.cpp 346c8cd 

Diff: https://git.reviewboard.kde.org/r/117836/diff/


Testing
-------

Everything language/project related still passes (except cmakeprojectvisitortest, but it doesn't work for me either way.)


Thanks,

Sergey Kalinichev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/ccf6cffa/attachment.html>