Review Request 117922: Preliminary implementation of adjust signature helper

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117922/#review57108
-----------------------------------------------------------


I'm with Olivier - this must be unit tested. A good start would be writing unit tests for the ClangUtils functions. Then, building on top of that, we can bring in the assistant tests. Generally, depending on how long Kevin will need to get this stuff into KDevplatform, I would not be opposed to get this patch into kdev-clang and then port it onto the new interface in KDevplatform. But yes, Kevin should chime in here and give some input.


clangsupport.h
<https://git.reviewboard.kde.org/r/117922/#comment39798>

    QScopedPointer



util/clangutils.cpp
<https://git.reviewboard.kde.org/r/117922/#comment39799>

    take the prefix by const& 


- Milian Wolff


On May 1, 2014, 5:08 a.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117922/
> -----------------------------------------------------------
> 
> (Updated May 1, 2014, 5:08 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> This is a preliminary implementation of the adjust signature helper. It works fairly well under normal usage, but it runs into problems if the user starts trying to use it at a high frequency. There are some rather fundamental issues both due to the different information organization (files vs translation units) and due to the discrepencies between what KDevelop has in the text editor and what clang has in the translation units. Hopefully I can get some feedback on the implementation.
> 
> 
> Diffs
> -----
> 
>   clangsupport.h 1316f88 
>   clangsupport.cpp 5e3f464 
>   codecompletion/completionhelper.cpp dfaf6b3 
>   codegen/CMakeLists.txt 0b913bd 
>   codegen/clangcodeassistant.h PRE-CREATION 
>   codegen/clangcodeassistant.cpp PRE-CREATION 
>   codegen/clangsignatureassistant.h PRE-CREATION 
>   codegen/clangsignatureassistant.cpp PRE-CREATION 
>   tests/CMakeLists.txt c2fd36d 
>   util/clangutils.h 3516821 
>   util/clangutils.cpp a74017c 
> 
> Diff: https://git.reviewboard.kde.org/r/117922/diff/
> 
> 
> Testing
> -------
> 
> Manual. Any unit tests would be deeply tied into the GUI, so I'm not sure how to go about writing those. The old c++ plugin unfortunately doesn't have any tests to work off of.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140502/6600fff0/attachment.html>