Review Request 117213: Fix for importing a CMake project with missing directories

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117213/#review54729
-----------------------------------------------------------

Ship it!


Looks good, thanks for taking care of this!

Do you have committing privileges? otherwise I'll push it myself.

- Aleix Pol Gonzalez


On March 31, 2014, 5:53 p.m., Pavel Petrushkov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117213/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 5:53 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Bugs: 332728
>     http://bugs.kde.org/show_bug.cgi?id=332728
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Importing project with nonexisting, but added in add_subdirectory() directories no longer causes KDevelop to load forever. Problem was in creating CMakeCommitChangesJob before checking if directory actually exists.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/cmakeimportjob.cpp 6b0143f 
> 
> Diff: https://git.reviewboard.kde.org/r/117213/diff/
> 
> 
> Testing
> -------
> 
> Successfully loaded project mentioned in bug report, other projects also seem to load correctly.
> 
> 
> Thanks,
> 
> Pavel Petrushkov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140331/11c5a999/attachment-0001.html>