Review Request 116842: Added virtual override completion to kdev-clang
David Stevens
dgedstevens at gmail.com
Sun Mar 23 19:53:00 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116842/
-----------------------------------------------------------
(Updated March 23, 2014, 7:53 p.m.)
Review request for KDevelop.
Changes
-------
Moved the logic which finds the overridable functions into its own class and added unit tests.
Repository: kdev-clang
Description
-------
Added virtual override completion to kdev-clang. Regular functions, template functions, and pure functions work. Signals and slots don't work, and const-qualified functions lose their qualifier. I'm not sure if the UI is completely correct.
Diffs (updated)
-----
codecompletion/CMakeLists.txt ec8f690
codecompletion/context.h aa6fcfb
codecompletion/context.cpp f6e85d6
codecompletion/overridecompletionhelper.h PRE-CREATION
codecompletion/overridecompletionhelper.cpp PRE-CREATION
tests/CMakeLists.txt c51dc22
tests/codecompletiontest.h PRE-CREATION
tests/codecompletiontest.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/116842/diff/
Testing (updated)
-------
Manual testing and basic unit tests.
Thanks,
David Stevens
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140323/ecdf70a6/attachment-0001.html>
More information about the KDevelop-devel
mailing list