Review Request 116988: Removed the cancel always-focus in the build configuration dialog

[Simon Wächter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116988/
-----------------------------------------------------------

(Updated March 23, 2014, 7:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop and Sven Brauch.


Repository: kdevelop


Description
-------

Removed the focus of the cancel button after the build configuration dialog creation. With this patch, the KDialog will follow the typical Enter(Accept) and Escape(Reject) KDE usability rule.


Diffs
-----

  projectmanagers/cmake/cmakebuilddirchooser.cpp 1ca3e4a 

Diff: https://git.reviewboard.kde.org/r/116988/diff/


Testing
-------

- With a valid build configuration, the ok button has the focus - otherwise disabled. The user can press Enter and the build configuration is done. Without this patch, the cancel button has the focus, even with a valid configuration
- As soon the user changes a value in the dialog, the dialog will use the Enter/Escape rule
- An invalid configuration does not allow an accept. The ok button is not enabled


Thanks,

Simon Wächter

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140323/0826721c/attachment.html>