Review Request 116897: Allow only 3 arguments to cmake command set_property

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116897/#review53451
-----------------------------------------------------------


This review has been submitted with commit 6485096e299eeb667d2d0a3729746f8770f636ff by Aleix Pol on behalf of Alexander Stein to branch master.

- Commit Hook


On March 19, 2014, 4:24 p.m., Alexander Stein wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116897/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 4:24 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> The llvm cmake build system generates (among others) this line:
> set_property(GLOBAL PROPERTY LLVMBUILD_LIB_DEPS_LLVMSupport )
> set_property only has 3 arguments which is fine, even cmake documentation for this command says the value is optional.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/parser/cmakeast.cpp f39ab0b 
>   projectmanagers/cmake/tests/cmakeasttest.cpp 6f4d5a9 
> 
> Diff: https://git.reviewboard.kde.org/r/116897/diff/
> 
> 
> Testing
> -------
> 
> ctest -R cmakeasttest runs without error
> 
> 
> Thanks,
> 
> Alexander Stein
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140319/178d1512/attachment.html>