Review Request 116842: Added virtual override completion to kdev-clang

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116842/#review53447
-----------------------------------------------------------


This looks awesome, really many thanks for working on it. The only thing missing is a unit test suite. Do you need help with setting that up?


codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37590>

    this you can replace by a {} in the info line below



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37591>

    whitespace after comma please :P



codecompletion/context.cpp
<https://git.reviewboard.kde.org/r/116842/#comment37592>

    whitespace :P


- Milian Wolff


On March 19, 2014, 7:11 p.m., David Stevens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116842/
> -----------------------------------------------------------
> 
> (Updated March 19, 2014, 7:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Added virtual override completion to kdev-clang. Regular functions, template functions, and pure functions work. Signals and slots don't work, and const-qualified functions lose their qualifier. I'm not sure if the UI is completely correct.
> 
> 
> Diffs
> -----
> 
>   codecompletion/context.h aa6fcfb 
>   codecompletion/context.cpp f6e85d6 
> 
> Diff: https://git.reviewboard.kde.org/r/116842/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> 
> Thanks,
> 
> David Stevens
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140319/3f0ad90d/attachment.html>