Review Request 116772: Fix dvcs test break

Shubham Chaudhary shubham.chaudhary at kdemail.net
Sat Mar 15 22:52:11 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116772/
-----------------------------------------------------------

(Updated March 16, 2014, 4:22 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdevplatform


Description
-------

AFAICS We don't need to call jobIsReady if there is some error, SlotProcessError is supposed do that already. This patch fixes the broken dvcsTest.


Diffs
-----

  vcs/dvcs/dvcsjob.cpp 30a3fcc 

Diff: https://git.reviewboard.kde.org/r/116772/diff/


Testing
-------

Totals: 3 passed, 0 failed, 0 skipped
********* Finished testing of DVcsJobTest *********


Thanks,

Shubham Chaudhary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140315/42abfb79/attachment.html>


More information about the KDevelop-devel mailing list