Review Request 116671: Detect "#aarrggbb" strings as being colors

Denis Steckelmacher steckdenis at yahoo.fr
Sun Mar 9 15:34:27 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116671/
-----------------------------------------------------------

(Updated March 9, 2014, 3:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDevelop.


Repository: kdev-qmljs


Description
-------

When the user leaves its mouse over a string formatted like an "#aarrggbb" color, a color picker appears. The QML-JS plugin was already able to detect named, #rgb and #rrggbb colors, and this commits adds the recognition of #aarrggbb colors, but does not extend the color picker itself for it to be able to display the opacity channel of colors. "#80ffffff" is displayed as completely opaque white.


Diffs
-----

  kdevqmljsplugin.cpp 8ff0d74 

Diff: https://git.reviewboard.kde.org/r/116671/diff/


Testing
-------

Strings like "#23e", "blue", "#9c2703" and "#80ffffff" are recognized as colors and a color picker is displayed. The opacity channel of colors is ignored but everything else works.


Thanks,

Denis Steckelmacher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140309/5e364652/attachment.html>


More information about the KDevelop-devel mailing list