Review Request 116671: Detect "#aarrggbb" strings as being colors

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116671/#review52441
-----------------------------------------------------------

Ship it!


Cool. Of course selecting opacity would be nice, but not that important.

- Sven Brauch


On March 9, 2014, 3:20 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116671/
> -----------------------------------------------------------
> 
> (Updated March 9, 2014, 3:20 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> When the user leaves its mouse over a string formatted like an "#aarrggbb" color, a color picker appears. The QML-JS plugin was already able to detect named, #rgb and #rrggbb colors, and this commits adds the recognition of #aarrggbb colors, but does not extend the color picker itself for it to be able to display the opacity channel of colors. "#80ffffff" is displayed as completely opaque white.
> 
> 
> Diffs
> -----
> 
>   kdevqmljsplugin.cpp 8ff0d74 
> 
> Diff: https://git.reviewboard.kde.org/r/116671/diff/
> 
> 
> Testing
> -------
> 
> Strings like "#23e", "blue", "#9c2703" and "#80ffffff" are recognized as colors and a color picker is displayed. The opacity channel of colors is ignored but everything else works.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140309/2bf7b70b/attachment.html>