Review Request 116655: Virtual override code completion in kdev-clang

David Stevens dgedstevens at gmail.com
Fri Mar 7 22:47:35 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116655/
-----------------------------------------------------------

(Updated March 7, 2014, 10:47 p.m.)


Review request for KDevelop.


Repository: kdev-clang


Description
-------

Ported some code completion functionallity from the existing c++ plugin to kdev-clang. Virtual override completion works for regular functions (not templated functions or signals/slots). Global identifier completion seems to work, although it wasn't the main focus of the work, so some part might have slipped through.


Diffs
-----

  codecompletion/CMakeLists.txt ec8f690 
  codecompletion/context.h aa6fcfb 
  codecompletion/context.cpp f6e85d6 
  codecompletion/helpers.h PRE-CREATION 
  codecompletion/helpers.cpp PRE-CREATION 
  codecompletion/implementationhelperitem.h PRE-CREATION 
  codecompletion/implementationhelperitem.cpp PRE-CREATION 
  codecompletion/item.h PRE-CREATION 
  codecompletion/item.cpp PRE-CREATION 
  codecompletion/model.cpp 92cec37 
  duchain/CMakeLists.txt d21011a 
  duchain/adlhelper.h PRE-CREATION 
  duchain/adlhelper.cpp PRE-CREATION 
  duchain/cppduchain.h PRE-CREATION 
  duchain/cppduchain.cpp PRE-CREATION 
  duchain/cpptypes.h PRE-CREATION 
  duchain/cpptypes.cpp PRE-CREATION 
  duchain/cursorkindtraits.h f079380 
  duchain/overloadresolution.h PRE-CREATION 
  duchain/overloadresolution.cpp PRE-CREATION 
  duchain/overloadresolutionhelper.h PRE-CREATION 
  duchain/overloadresolutionhelper.cpp PRE-CREATION 
  duchain/parsesession.h 0abf38f 
  duchain/templatedeclaration.h PRE-CREATION 
  duchain/templatedeclaration.cpp PRE-CREATION 
  duchain/templateparameterdeclaration.h PRE-CREATION 
  duchain/templateparameterdeclaration.cpp PRE-CREATION 
  duchain/templateresolver.h PRE-CREATION 
  duchain/templateresolver.cpp PRE-CREATION 
  duchain/tuduchain.h d1a863a 
  duchain/typeconversion.h PRE-CREATION 
  duchain/typeconversion.cpp PRE-CREATION 
  duchain/typeutils.h PRE-CREATION 
  duchain/typeutils.cpp PRE-CREATION 
  duchain/viablefunctions.h PRE-CREATION 
  duchain/viablefunctions.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/116655/diff/


Testing
-------

Basic manual testing.


Thanks,

David Stevens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140307/1de5f6e1/attachment.html>


More information about the KDevelop-devel mailing list