Review Request 116590: Fix assign nested tuple unpacking

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116590/#review52366
-----------------------------------------------------------



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/116590/#comment37068>

    Why do you take a reference to an AST here? It's not done like this anywhere else and just introduces additional clutter into the code. Just take a const Ast*.



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/116590/#comment37069>

    same here, take a const Ast*



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/116590/#comment37070>

    Are there not more things which can be unpacked? Sets, for example?
    But as said, I don't care much -- in python 3 it works, do whatever floats your boat feature-wise here.



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/116590/#comment37072>

    once you use append, once << ...? ;)



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/116590/#comment37073>

    why the flatten? get_elements already returns a flat list, right?


- Sven Brauch


On March 7, 2014, 9:15 a.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116590/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 9:15 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Bugs: 314024
>     http://bugs.kde.org/show_bug.cgi?id=314024
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Old code use 2 level loop for unpack left tuple, but need recursion.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2de9bba 
>   duchain/declarationbuilder.cpp 400ec1d 
> 
> Diff: https://git.reviewboard.kde.org/r/116590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140307/5e51da13/attachment-0001.html>