Review Request 116530: Better handling of VCS error during init and commit

[Shubham Chaudhary]

Cool, I'll push it tonight :)

--

Regards,
Shubham Chaudhary (UTC +05:30)
http://www.shubhamchaudhary.in
Sent from BlackBerry®

-----Original Message-----
From: "Kevin Funk" <kfunk at kde.org>
Sender: "Kevin Funk" <noreply at kde.org>
Date: Thu, 06 Mar 2014 13:09:29 
To: Kevin Funk<kfunk at kde.org>; Shubham Chaudhary<shubham.chaudhary at kdemail.net>; KDevelop<kdevelop-devel at kde.org>
Reply-To: "Kevin Funk" <kfunk at kde.org>
Subject: Re: Review Request 116530: Better handling of VCS error during init and
 commit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/#review52248
-----------------------------------------------------------

Ship it!


Looks really good now, just tested locally. Works fine for me.

Please address the few issues, then you may ship this.

And please avoid large whitespaces changes in patches like this in future. (Configure your editor to not to trim whitespace automatically on *every* line)


plugins/appwizard/appwizardplugin.cpp
<https://git.reviewboard.kde.org/r/116530/#comment37024>

    Rather do
    (job ? job->errorString() : QString())



vcs/dvcs/dvcsjob.cpp
<https://git.reviewboard.kde.org/r/116530/#comment37023>

    Simply do
    QString completeErrorText = i18n("Process '%1' exited with status %2\n%3", d->childproc->program().join(" "), d->childproc->exitCode(), d->errorOutput )



vcs/widgets/vcsdiffpatchsources.cpp
<https://git.reviewboard.kde.org/r/116530/#comment37025>

    Same here
    (stmt ? stmt : stmt)


- Kevin Funk


On March 5, 2014, 10:49 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116530/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 10:49 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 327931
>     http://bugs.kde.org/show_bug.cgi?id=327931
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch does the following 2 things:
> * Shows detailed failure information through vcsError function when initialization fails.
> * Checks  the status of commit job, if unsuccessful shows a error KMessageBox.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizardplugin.cpp 17d556b 
>   vcs/dvcs/dvcsjob.cpp 6c2275a 
>   vcs/widgets/vcsdiffpatchsources.h 295522f 
>   vcs/widgets/vcsdiffpatchsources.cpp 77144d9 
> 
> Diff: https://git.reviewboard.kde.org/r/116530/diff/
> 
> 
> Testing
> -------
> 
> Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140306/f5d68622/attachment-0001.html>