Review Request 115722: Import fixits from Clang

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115722/#review52083
-----------------------------------------------------------



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36982>

    here you can just use m_fixits



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36983>

    the constPtr is only required here, so put it only here
    
    if (!m_fixits.isEmpty()) {
      results[{this}] = m_fixits;
    }


- Milian Wolff


On March 5, 2014, 2:10 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115722/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 2:10 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Import fixits from Clang
> 
> REVIEW: 115722
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt f3ac17e69f5084d6ed72946e54615166f47ce5d8 
>   duchain/clangproblem.h PRE-CREATION 
>   duchain/clangproblem.cpp PRE-CREATION 
>   duchain/parsesession.cpp 6f9ed5b7537f286d83b540e90b5e57c04ffa749b 
>   tests/test_problems.h 7df526ec44dd02c5e6e9e5eb42c560fda663f9f7 
>   tests/test_problems.cpp e3f42d61223df86551951c5533fb49477c8bf016 
> 
> Diff: https://git.reviewboard.kde.org/r/115722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140305/b34e3d9d/attachment-0001.html>