Review Request 115722: Import fixits from Clang

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115722/#review52081
-----------------------------------------------------------



duchain/clangproblem.h
<https://git.reviewboard.kde.org/r/115722/#comment36972>

    using ClangFixits = QVector<ClangFixit>



duchain/clangproblem.h
<https://git.reviewboard.kde.org/r/115722/#comment36973>

    this will not be persisted, but the data looks persistable in theory - will you work on this in a future commit?



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36974>

    braces please



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36975>

    return {};



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36976>

    this const_cast is ugly, why is this required?



duchain/clangproblem.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36977>

    please scope the lock instead of unlocking it manually



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36979>

    ClangProblem::Ptr



duchain/parsesession.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36978>

    ClangProblem::Ptr



tests/test_problems.cpp
<https://git.reviewboard.kde.org/r/115722/#comment36980>

    yay! thanks for that


- Milian Wolff


On March 4, 2014, 10:24 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115722/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 10:24 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-clang
> 
> 
> Description
> -------
> 
> Import fixits from Clang
> 
> REVIEW: 115722
> 
> 
> Diffs
> -----
> 
>   duchain/CMakeLists.txt f3ac17e69f5084d6ed72946e54615166f47ce5d8 
>   duchain/clangproblem.h PRE-CREATION 
>   duchain/clangproblem.cpp PRE-CREATION 
>   duchain/parsesession.cpp 6f9ed5b7537f286d83b540e90b5e57c04ffa749b 
>   tests/test_problems.h 7df526ec44dd02c5e6e9e5eb42c560fda663f9f7 
>   tests/test_problems.cpp e3f42d61223df86551951c5533fb49477c8bf016 
> 
> Diff: https://git.reviewboard.kde.org/r/115722/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140305/21602b3a/attachment.html>