Review Request 116590: Fix assign nested tuple unpacking

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116590/#review51861
-----------------------------------------------------------


Thanks for the patch! However, I consider this a feature. I would not want it to go into 1.6. Can you please do it against master? Shouldn't be much to do, mostly remove the C++11 flag.

Also, this is already implemented in the python 3 branch in a different way... so it causes some divergence. But okay.


duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/116590/#comment36902>

    use auto?


- Sven Brauch


On March 4, 2014, 8:54 a.m., Alexandr Zamaraev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116590/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 8:54 a.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Bugs: 314024
>     http://bugs.kde.org/show_bug.cgi?id=314024
> 
> 
> Repository: kdev-python
> 
> 
> Description
> -------
> 
> Old code use 2 level loop for unpack left tuple, but need recursion.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.cpp 400ec1d 
>   CMakeLists.txt 2de9bba 
> 
> Diff: https://git.reviewboard.kde.org/r/116590/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexandr Zamaraev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140304/ad2623bc/attachment.html>