Review Request 116530: Better handling of VCS error during init and commit

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/#review51857
-----------------------------------------------------------


You probably have to connect to the KJob::finished signal instead. And please make sure that the message box contains the actual error output.


vcs/widgets/vcsdiffpatchsources.cpp
<https://git.reviewboard.kde.org/r/116530/#comment36900>

    Rename to something like 'jobFinished'



vcs/widgets/vcsdiffpatchsources.cpp
<https://git.reviewboard.kde.org/r/116530/#comment36899>

    Connect to finished() signal instead?


- Kevin Funk


On March 3, 2014, 8:11 p.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116530/
> -----------------------------------------------------------
> 
> (Updated March 3, 2014, 8:11 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 327931
>     http://bugs.kde.org/show_bug.cgi?id=327931
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch does the following 2 things:
> * Shows detailed failure information through vcsError function when initialization fails.
> * Checks  the status of commit job, if unsuccessful shows a error KMessageBox.
> 
> 
> Diffs
> -----
> 
>   vcs/widgets/vcsdiffpatchsources.cpp 77144d9 
>   vcs/dvcs/dvcsjob.cpp 6c2275a 
>   vcs/widgets/vcsdiffpatchsources.h 295522f 
>   plugins/appwizard/appwizardplugin.cpp 17d556b 
> 
> Diff: https://git.reviewboard.kde.org/r/116530/diff/
> 
> 
> Testing
> -------
> 
> Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140304/d32b3892/attachment-0001.html>