Review Request 116530: Better handling of VCS error during init and commit

[Shubham Chaudhary]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/
-----------------------------------------------------------

(Updated March 4, 2014, 1:41 a.m.)


Review request for KDevelop.


Changes
-------

So I created this new slot. As such there is no finished signal for VcsJob so I used resultReady instead. In principle this thing should work. I also ensure that resultReady is emitted when the job is finished, and it is actually emitted at the moment we want it to, but it never enters the slot!


Bugs: 327931
    http://bugs.kde.org/show_bug.cgi?id=327931


Repository: kdevplatform


Description
-------

Patch does the following 2 things:
* Shows detailed failure information through vcsError function when initialization fails.
* Checks  the status of commit job, if unsuccessful shows a error KMessageBox.


Diffs (updated)
-----

  vcs/widgets/vcsdiffpatchsources.cpp 77144d9 
  vcs/dvcs/dvcsjob.cpp 6c2275a 
  vcs/widgets/vcsdiffpatchsources.h 295522f 
  plugins/appwizard/appwizardplugin.cpp 17d556b 

Diff: https://git.reviewboard.kde.org/r/116530/diff/


Testing
-------

Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.


Thanks,

Shubham Chaudhary

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140303/03b1c32b/attachment.html>