Review Request 116530: Better handling of VCS error during init and commit

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116530/#review51643
-----------------------------------------------------------


Just tested by committing sth with .gitconfig removed. The details box in the 'Commit unsuccesful' doesn't list the real error string for me, it just tells me to look at the VCS tool view. Why's that?

It should rather show the Git output right in the dialog, i.e.:

*** Please tell me who you are.

"""
Run

  git config --global user.email "you at example.com"
  git config --global user.name "Your Name"

...
"""




plugins/appwizard/appwizardplugin.cpp
<https://git.reviewboard.kde.org/r/116530/#comment36699>

    job might be null here, according to the if-condition



vcs/widgets/vcsdiffpatchsources.cpp
<https://git.reviewboard.kde.org/r/116530/#comment36700>

    job might be null here, according to the if-condition


- Kevin Funk


On March 2, 2014, 11:17 a.m., Shubham Chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116530/
> -----------------------------------------------------------
> 
> (Updated March 2, 2014, 11:17 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Bugs: 327931
>     http://bugs.kde.org/show_bug.cgi?id=327931
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Patch does the following 2 things:
> * Shows detailed failure information through vcsError function when initialization fails.
> * Checks  the status of commit job, if unsuccessful shows a error KMessageBox.
> 
> 
> Diffs
> -----
> 
>   plugins/appwizard/appwizardplugin.cpp 17d556b 
>   vcs/widgets/vcsdiffpatchsources.cpp 77144d9 
> 
> Diff: https://git.reviewboard.kde.org/r/116530/diff/
> 
> 
> Testing
> -------
> 
> Manually tested for both cases with .gitconfig removed, so author's name and email is not available to git.
> 
> 
> Thanks,
> 
> Shubham Chaudhary
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140302/4628f63b/attachment.html>