Review Request 118881: Port to new Kate status bar

[Aleix Pol Gonzalez]

> On June 30, 2014, 7:21 a.m., Kevin Funk wrote:
> > @KDevelop team: Opinions?
> 
> Milian Wolff wrote:
>     I'd personally prefer if we could keep (part of) the current code around... Personally, I think the contents of the Kate status bar are completely overkill and contain far too many action one rarely has to look at. Esp. in split view, this will look horribly cluttered.
>     
>     But I can completely understand that the information is crucial for those that use the VI mode. And probably for people who work on foreign code where they  need to change the indentation or mode and stuff regularly.
>     
>     So could we maybe get this in, with the ability to configure this? What to others think? I'm open for the discussion here.
> 
> Aleix Pol Gonzalez wrote:
>     TBH I'm not a big fan of the status bar either, we're losing some nice vertical space.
>     
>     On the other hand, I think we want to re-think parts of the UI for kdev5, so I'd suggest to have this merged and reviewed with the rest of the UI. For starters, having a way to show/hide would be enough I'd say.
> 
> Sven Brauch wrote:
>     In the past, we did show a status bar only when VI mode is on. Why not keep it like this?
> 
> Miquel Sabaté Solà wrote:
>     I agree with Sven. As a vi-mode user myself I appreciate that there is status bar when Vi mode is on (and no, the shape of the cursor is not enough :P). Besides vi, I honestly think that this new status bar is a bit overkill (e.g. I've never had to change the encoding of a document in a KDevelop project).

Maybe we could have something like "only show it when Control is pressed", so one can still interact with it. The problem being, that when pressing shortcuts, things would flash down there.


- Aleix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118881/#review61249
-----------------------------------------------------------


On June 22, 2014, 4:03 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118881/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 4:03 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port to new Kate status bar
> 
> Drop the custom status label in the upper right corner
> 
> 
> Diffs
> -----
> 
>   sublime/container.cpp eded49f0fc16f56f62e96f65c8c3ae44818cd2ed 
>   shell/uicontroller.cpp 188f26c7e03145eaaa852071d68a984a434eafe2 
>   shell/textdocument.cpp dcc7c9cb35901bf741dc618e4d620dd12a0433d1 
>   shell/textdocument.h 26f4ba8462e4d5f466f82b2b630ff79f83c85066 
>   shell/CMakeLists.txt 61205a6fc0679f92a0f21fad29bd6c719238a409 
> 
> Diff: https://git.reviewboard.kde.org/r/118881/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> kdevelop-editorview-before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/25bde517-bc8f-4ed6-a4c6-f2c7e14f5a13__kdevelop-editorview-before.png
> kdevelop-editorview-after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/0707d702-2a76-41e5-8dc1-10aa85dbbd35__kdevelop-editorview-after.png
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140630/e52ea913/attachment.html>