Review Request 118881: Port to new Kate status bar

[Kevin Funk]

> On June 22, 2014, 5:07 p.m., Milian Wolff wrote:
> > Is the status bar always shown? I don't like how much space it requires... still - better than no status bar at all for the VI people, I guess...
> 
> Dominik Haumann wrote:
>     Milian, search for "statusbar" at http://api.kde.org/frameworks-api/frameworks5-apidocs/ktexteditor/html/kte_port_to_5.html
>     
>     In my opinion, you should try the default status bar for KF5. If it turns out to be a problem, you can still change it.
>     Btw, when you show the command line or any other view bar on the bottom (search, goto, ...), the status bar is hidden. So at least here, we have a good tradeoff.

Well, I don't like the duplicate information (line, column) in the view. Maybe it makes sense if I revert most of the changes, but only show the information in the upper right corner in case the status bar is disabled. I'll add an action to show/hide the status bar then.

Being able to remove around 200 LOC of duplicate functionality just got me a bit overeager. I agree, that for normal use-cases the status bar is a bit too much.

@Milian: Regarding VI mode: The command-mode edit line still shows up even if the status bar is hidden. So it's not a big issue, I think. You can deduce being either in insert or visual by looking at the cursor style.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118881/#review60721
-----------------------------------------------------------


On June 22, 2014, 4:03 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118881/
> -----------------------------------------------------------
> 
> (Updated June 22, 2014, 4:03 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Port to new Kate status bar
> 
> Drop the custom status label in the upper right corner
> 
> 
> Diffs
> -----
> 
>   sublime/container.cpp eded49f0fc16f56f62e96f65c8c3ae44818cd2ed 
>   shell/uicontroller.cpp 188f26c7e03145eaaa852071d68a984a434eafe2 
>   shell/textdocument.cpp dcc7c9cb35901bf741dc618e4d620dd12a0433d1 
>   shell/textdocument.h 26f4ba8462e4d5f466f82b2b630ff79f83c85066 
>   shell/CMakeLists.txt 61205a6fc0679f92a0f21fad29bd6c719238a409 
> 
> Diff: https://git.reviewboard.kde.org/r/118881/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> kdevelop-editorview-before.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/25bde517-bc8f-4ed6-a4c6-f2c7e14f5a13__kdevelop-editorview-before.png
> kdevelop-editorview-after.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/0707d702-2a76-41e5-8dc1-10aa85dbbd35__kdevelop-editorview-after.png
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140622/818ba098/attachment.html>