Review Request 118819: Simplify AssistantPopup related code

[Kevin Funk]

> On June 18, 2014, 9:59 p.m., Milian Wolff wrote:
> > shell/assistantpopup.cpp, line 208
> > <https://git.reviewboard.kde.org/r/118819/diff/1/?file=282438#file282438line208>
> >
> >     is this still required?

Bah. Review board ate this comment.

So, the problem is that I'm not getting key press events for Alt+1 in the event filter for example. I'm not exactly sure why. I'd vote for getting this in as an initial version, though. We can investigate later if we can get rid off the focus switching altogether.

Maybe Sven also has some input regarding the missing key press event(?)


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118819/#review60451
-----------------------------------------------------------


On June 18, 2014, 9:44 p.m., Kevin Funk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118819/
> -----------------------------------------------------------
> 
> (Updated June 18, 2014, 9:44 p.m.)
> 
> 
> Review request for KDevelop and Sven Brauch.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> Simplify AssistantPopup related code
> 
> Get rid off most JS logic inside QML, make it a lot more declarative.
> I'm not sure if I've fixed the losing-focus bug, but I cannot reproduce
> it anymore.
> 
> 
> Diffs
> -----
> 
>   shell/assistantpopup.qml 69ccc2f9f833567e70406e04bae040392ae3f961 
>   shell/assistantpopup.cpp 1f3ff012a51dbab6f1d0c75149e3cf712f1ec449 
>   shell/assistantpopup.h 475cc37c5b205d213adec7fb03c71e5a81f05749 
>   shell/AssistantButton.qml ac3d27bb6eee21a99a04005b62a3a3ef5d5c1930 
> 
> Diff: https://git.reviewboard.kde.org/r/118819/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Funk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140619/16dbde65/attachment-0001.html>