Review Request 118552: Further development of adjust signature assistant

David Stevens dgedstevens at
Wed Jun 18 03:29:11 UTC 2014

This is an automatically generated e-mail. To reply, visit:

(Updated June 18, 2014, 3:29 a.m.)

Review request for KDevelop.


Update to work with the new assistant infrastructure.

Repository: kdev-clang


Improvements which make the assistant behave more consistently.

However, making it work in as many cases as possible will require work on the core of kdev-clang. This is because it runs into issues where a header file cached in a translation unit is 'stale' (when it has been changed and saved since the translation unit was parsed). This breaks location queries in the cached header file, and I don't think there's any good way to avoid such queries while trying to implement the signature adjustment functionallity. Thoughts?

Diffs (updated)

  codegen/clangsignatureassistant.h 7048d2d 
  codegen/clangsignatureassistant.cpp 07357ff 
  tests/CMakeLists.txt 7251ce9 
  tests/test_assistants.h PRE-CREATION 
  tests/test_assistants.cpp PRE-CREATION 
  util/clangutils.h cc0565d 
  util/clangutils.cpp 9553742 



Added unit tests. Each test case passes if run individually, but they don't quite work if run as a group. I believe this is due to issues with the code assistant, so I didn't really bother looking into it because of Kevin's current work in that area.


David Stevens

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the KDevelop-devel mailing list