Review Request 118743: Make every QML/JS file see the other QML/JS files in its directory

Sat Jun 14 19:43:58 UTC 2014

> On June 14, 2014, 6:51 p.m., Sven Brauch wrote:
> > duchain/declarationbuilder.cpp, line 87
> > <https://git.reviewboard.kde.org/r/118743/diff/1/?file=281148#file281148line87>
> >
> >     Hm, this seems backward to me. I would prefer if you did it like "if a.qml is parsed, it looks for other files in the directory and imports them."
> >     
> >     For example, if you open all the files initially, will highlighting be correct (i.e. include highlighting for stuff from imported contexts) if they are parsed in the wrong order? I don't tihnk so, because you don't tell it to update the highlighting anywhere.
> 
> Denis Steckelmacher wrote:
>     ParseSession::contextOfFile returns the TopDUContext of a given file. If the file has not yet been parsed by KDevelop, then a new parse job is scheduled for it and for the current file. This way, the order in which files are parsed has no importance:
>     
>     * The first file to be parsed will schedule the parsing of all the other files, and will be parsed "as is", that is to say without any information about the QML components available in the current directory.
>     * Every file in the directory will be parsed. Each file will be able to immediately see the files that have already been parsed, and will make a link (in both directions) between it and the already-parsed files. This makes sense because the already-parsed files were not able to see this file and miss an import statement for it. Import statements are created only the first time a file is parsed, so there is no chance a duplicate is created. Every file (but the last one) will also be scheduled for a reparse, because it tried to import a file that has not yet been parsed.
>     * The last file that is explored is able to see all the others and is happy, and registers itself into all the other files of the directory. Now that every file has been parsed and has either been able to see some files, or was updated by other files when they were parsed, every file has an import statement for every other file.
>     * Every file (but the last one) now gets re-parsed, because some files were missing the first time they were parsed and they are now complete. QmlParseJob calls highlightDuchain, which gets the highlighting right (I think).
>     
>     I agree that it is somewhat complicated (in fact, I've thought about this problem for several days and it is difficult to have a code that is simple yet efficient). I'm not quite happy that most of the files of a directory need to be parsed two times (and each time requires two passes), but I think that it is the only solution: every file must be parsed a first time to build its TopDUContext, then these TopDUContexts can be added to all the other files that need to be reparsed now that new declarations become visible.

Hmm, so, why do you need to modify top-contexts other than the one you're currently building? Can't you just leave that out in that case? It should still work if each file just imports the already-built ones and then reschedules itself in case there's still missing files.

> On June 14, 2014, 6:51 p.m., Sven Brauch wrote:
> > duchain/parsesession.cpp, line 221
> > <https://git.reviewboard.kde.org/r/118743/diff/1/?file=281150#file281150line221>
> >
> >     I dislike this method's name, it doesn't sound like it does something ...
> 
> Denis Steckelmacher wrote:
>     I agree. What about "topDUContextOrScheduleForParsing" (maybe a bit too long) or "contextIfAvailable" or "topDUContextOrParse"?

Meh, I guess that doesn't really make it better. I can't come up with a name either. Maybe it's best to just add a docstring saying what it does. ;)

> On June 14, 2014, 6:51 p.m., Sven Brauch wrote:
> > duchain/parsesession.cpp, line 228
> > <https://git.reviewboard.kde.org/r/118743/diff/1/?file=281150#file281150line228>
> >
> >     keep the lock while you access the context
> 
> Denis Steckelmacher wrote:
>     Humm, the only lines after this one that play with the context (moduleContext) only call ReferencedTopDUContext::operator bool(), that doesn't require a DUChain lock. Moreover, queueing parse jobs does not require the DUChain lock (I think, maybe I'm wrong here) and can take quite a long time to execute.

Ah, alright then, I didn't read the following code carefully. operator bool() should really be safe.

- Sven

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118743/#review60093
-----------------------------------------------------------

On June 14, 2014, 1 p.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118743/
> -----------------------------------------------------------
> 
> (Updated June 14, 2014, 1 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> If a directory contains a.js, b.js and c.js, a.js imports b.js and c.js, b.js imports a.js and c.js, and c.js imports a.js and b.js. This way, every file can see the declarations of all the other files. This brings two important features:
> 
> * The same code is used for QML files. Because this patch also declares the top-level component of a MyComponent.qml QML file as MyComponent, QML files can now instantiate the top-level component of other files. This is the "custom components" feature.
> * Javascript files generally don't contain import statements, and it is difficult to know which declarations should be visible in a file. With this patch, every file can see the others in the same directory. This is already quite useful because the majority of the Javascript developers put all their files in the same directory (mysite.js uses the jquery.js file stored along it).
> * QML files can see JS files and the other way around. This may be useful if an user writes a JS files designed to be used by a QML file (I think it is possible to share code between the QML and the Javascript worlds) because the QML components will be visible in the JS files (that can instantiate them), and the JS functions/objects can be used in QML slots.
> 
> This patch is a bit simpler than what I've imagined, but here are some remarks that I have about the code:
> 
> * I use QFileInfo because I've not found a static method that takes a file path and returns the path of its parent directory (a simple section('/', 0, -2) would have been enough if every operating system used / separators). QDirIterator is easy to use, but is it okay to use these classes in KDE code?
> * Every file includes every other file in the same directory. When there are many files in a directory, this can become quite huge, but KDevelop seems to handle imported parent contexts in a quite efficient manner.
> * I filter out the files in /kdevqmljssupport/, because they are big and numerous. I don't want all 24 of them to include all the others and to be parsed every time KDevelop starts.
> * The "class" of the top-level QML component of a file is not anonymous anymore but has a name, hence the small changes in the unit tests.
> 
> 
> Diffs
> -----
> 
>   codecompletion/tests/qmlcompletiontest.cpp 7e32a16 
>   duchain/declarationbuilder.h 2744ffe 
>   duchain/declarationbuilder.cpp 5a9b830 
>   duchain/parsesession.h 8afc145 
>   duchain/parsesession.cpp 3133c80 
>   duchain/tests/testdeclarations.cpp 51b90a5 
>   tests/files/plugins.qml 9b1c0d4 
>   tests/files/test.qml 4b08b47 
>   tests/files/types.js 2428b89 
>   tests/files/uses.js bfbd6fc 
> 
> Diff: https://git.reviewboard.kde.org/r/118743/diff/
> 
> 
> Testing
> -------
> 
> Two tests are added: one declares a JS variable in a file and uses it in another file (and checks that the use count is 1), the other instantiates the top-level QML component of "test.qml" in "plugins.qml" and checks that the uses are okay.
> 
> Some other unit tests needed to be changed because top-level QML components now have a class name. With these changes, the whole testsuite continues to pass and has not been slowed down by this patch.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140614/59fae21d/attachment-0001.html>