Review Request 118481: Basic integration of Bazaar VCS

[Kevin Funk]

On Saturday 14 June 2014 00:27:14 Aleix Pol wrote:
> On Sat, Jun 14, 2014 at 12:25 AM, Maciej Poleski <
> 
> d82ks8djf82msd83hf8sc02lqb5gh5 at gmail.com> wrote:
> >    This is an automatically generated e-mail. To reply, visit:
> > https://git.reviewboard.kde.org/r/118481/
> > 
> >   This change has been marked as submitted.
> >   Review request for KDevelop.
> > 
> > By Maciej Poleski.
> > 
> > *Updated June 13, 2014, 10:25 p.m.*
> > 
> >  *Repository: * kdevplatform
> > 
> > Description
> > 
> > This patch adds basic integration of Bazaar VCS.
> > 
> > It provides implementation of KDevelop::IDistributedVersionControl
> > interface as a plugin. It works by forwarding (user) requests to bzr
> > executable (which must be in PATH) and parsing (text output) result from
> > spawned bzr process.> 
> >   Testing
> > 
> > - Manual testing
> > - Tests included
> > 
> >   Diffs
> >   
> >    - plugins/CMakeLists.txt (e0ccbc1)
> >    - plugins/bazaar/CMakeLists.txt (PRE-CREATION)
> >    - plugins/bazaar/bazaar.kdev4 (PRE-CREATION)
> >    - plugins/bazaar/src/CMakeLists.txt (PRE-CREATION)
> >    - plugins/bazaar/src/bazaarplugin.h (PRE-CREATION)
> >    - plugins/bazaar/src/bazaarplugin.cpp (PRE-CREATION)
> >    - plugins/bazaar/src/bazaarutils.h (PRE-CREATION)
> >    - plugins/bazaar/src/bazaarutils.cpp (PRE-CREATION)
> >    - plugins/bazaar/src/bzrannotatejob.h (PRE-CREATION)
> >    - plugins/bazaar/src/bzrannotatejob.cpp (PRE-CREATION)
> >    - plugins/bazaar/src/copyjob.h (PRE-CREATION)
> >    - plugins/bazaar/src/copyjob.cpp (PRE-CREATION)
> >    - plugins/bazaar/src/diffjob.h (PRE-CREATION)
> >    - plugins/bazaar/src/diffjob.cpp (PRE-CREATION)
> >    - plugins/bazaar/src/kdevbazaar.desktop.cmake (PRE-CREATION)
> >    - plugins/bazaar/tests/CMakeLists.txt (PRE-CREATION)
> >    - plugins/bazaar/tests/bazaartest.h (PRE-CREATION)
> >    - plugins/bazaar/tests/bazaartest.cpp (PRE-CREATION)
> > 
> > View Diff <https://git.reviewboard.kde.org/r/118481/diff/>
> 
> Can you please request a contributor account? You can use me as a referal.
> 
> http://techbase.kde.org/Contribute/Get_a_Contributor_Account
> 
> Aleix

Indeed.

You need that in order to commit fixes for the unit test failures :)

Just joking -- nice work on the bazaar plugin! Please make sure the unit tests 
[1] work.

Cheers

[1] 
http://build.kde.org/view/kdevelop/job/kdevplatform_master/924/testReport/(root)/TestSuite/kdevbazaar_test/

-- 
Kevin Funk