Review Request 118627: Add a test case for Bug 335803
Aleix Pol Gonzalez
aleixpol at kde.org
Mon Jun 9 14:32:32 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118627/#review59616
-----------------------------------------------------------
Ship it!
Oh, nice way to report a bug :), I'll look into it when I have some time.
- Aleix Pol Gonzalez
On June 9, 2014, 2:25 p.m., Alexander Richardson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118627/
> -----------------------------------------------------------
>
> (Updated June 9, 2014, 2:25 p.m.)
>
>
> Review request for KDevelop and Aleix Pol Gonzalez.
>
>
> Repository: kdevelop
>
>
> Description
> -------
>
> Also add a CMakeProjectVisitorTest for bug 335803
>
>
> Diffs
> -----
>
> projectmanagers/cmake/tests/cmakeloadprojecttest.h 9e5cf523e21aa2450b6819b1959906e0654256ad
> projectmanagers/cmake/tests/cmakeloadprojecttest.cpp 5a0b1ed52fac800247d6bf2e65afb0d64602020e
> projectmanagers/cmake/tests/cmakeprojectvisitortest.h c491b3bed0e8ab215fcb0a663f8d2e1c93e2f9e5
> projectmanagers/cmake/tests/cmakeprojectvisitortest.cpp 37498e8ddc4bb0ea4b8d0ddbc12b67756137d1a7
> projectmanagers/cmake/tests/manual/bug335803/CMakeLists.txt PRE-CREATION
> projectmanagers/cmake/tests/manual/bug335803/defines.kdev4 PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/118627/diff/
>
>
> Testing
> -------
>
> It doesn't pass, but I think I found the underlying issue. I don't know how to fix it since I am not familiar with the CMake parsing code, but hopefully this test case will help to fix it.
>
>
> Thanks,
>
> Alexander Richardson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140609/11c60051/attachment.html>
More information about the KDevelop-devel
mailing list