Review Request 118600: Support QML signal declarations

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118600/#review59517
-----------------------------------------------------------

Ship it!


A clever solution, certainly, and it is quite effective in avoiding code duplication ;)


duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/118600/#comment41445>

    why split this into two lines?



duchain/declarationbuilder.cpp
<https://git.reviewboard.kde.org/r/118600/#comment41447>

    Given that I've never seen this syntax before today, I think a comment explaining how this works could be beneficial ;)


- Sven Brauch


On June 7, 2014, 9:33 a.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118600/
> -----------------------------------------------------------
> 
> (Updated June 7, 2014, 9:33 a.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdev-qmljs
> 
> 
> Description
> -------
> 
> This patch adds support for QML signal declarations:
> 
> Item {
>     signal test(int param1, bool param2)
> }
> 
> The patch is not the nicest ever, but the QMLJS AST is especially bad here. First, QML signals and properties are both handled using a single UiPublicMember node (even if they are completely different things), and signals are declared in a completely different mean than Javascript function expressions or plugin.qmltypes signals. There are therefore three ways of declaring a function (a JS function, signals/methods in plugin.qmltypes files and plain QML signals), and the three ways cannot share any code because they use a completely different AST structure (FunctionExpression + FormalParameterList, "Signal { Parameter {...} Parameter {...} }", UiPublicMember + UiParameterList.
> 
> 
> Diffs
> -----
> 
>   duchain/declarationbuilder.h 1e6c895 
>   duchain/declarationbuilder.cpp 03ae915 
>   duchain/tests/testcontexts.cpp 4810f9c 
>   tests/files/test.qml d50e737 
> 
> Diff: https://git.reviewboard.kde.org/r/118600/diff/
> 
> 
> Testing
> -------
> 
> Two new unit tests have been added. The first one ensures that signals are properly declared (with their typed parameters), and the second one ensures that the "minimal" syntax for defining signals (without parameters) does not crash. All the other unit tests pass.
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140607/9a709f66/attachment.html>