Review Request 118521: Fixed a bug that made not to process the whole output of the tests in some cases.

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118521/#review59227
-----------------------------------------------------------



outputview/outputmodel.cpp
<https://git.reviewboard.kde.org/r/118521/#comment41246>

    Don't remove the comment please.



outputview/outputmodel.cpp
<https://git.reviewboard.kde.org/r/118521/#comment41245>

    This is wrong as well. d->worker lives in a different thread.
    
    Actually, this is a use-case for Qt::BlockingQueuedConnection, because you want to be sure that the current thread blocks until d->worker->flushBuffers() has been called.
    
    Hence: QMetaObject::invokeMethod(d->worker, "flushBuffers", Qt::BlockingQueuedConnection)
    
    
    


- Kevin Funk


On June 4, 2014, 11:33 a.m., Pepe Osca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118521/
> -----------------------------------------------------------
> 
> (Updated June 4, 2014, 11:33 a.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> The patch fixes a bug that made not to process some lines of the test output.
> 
> 
> Diffs
> -----
> 
>   outputview/outputmodel.h 8d249b4 
>   outputview/outputmodel.cpp a0fcafe 
>   plugins/execute/nativeappjob.cpp 22ad6d2 
> 
> Diff: https://git.reviewboard.kde.org/r/118521/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pepe Osca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140604/fadb2d53/attachment.html>