Review Request 118497: Tests output parsing fixed so that notification icons apperar properly.

[Milian Wolff]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118497/#review59086
-----------------------------------------------------------


are there no unit tests here? I'd welcome if one could be added to show what is fixed and why.


projectmanagers/cmake/testing/ctestrunjob.cpp
<https://git.reviewboard.kde.org/r/118497/#comment41122>

    I'd add a comment to explain what is matched here, i.e. an example line with some comment.



projectmanagers/cmake/testing/ctestrunjob.cpp
<https://git.reviewboard.kde.org/r/118497/#comment41123>

    whitespaces around operators please


- Milian Wolff


On June 3, 2014, 12:27 p.m., Pepe Osca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118497/
> -----------------------------------------------------------
> 
> (Updated June 3, 2014, 12:27 p.m.)
> 
> 
> Review request for KDevelop and Aleix Pol Gonzalez.
> 
> 
> Repository: kdevelop
> 
> 
> Description
> -------
> 
> Test output parsing had a small bug and correct icons were not showed in the view. This path is suppose to solve the problem.
> 
> 
> Diffs
> -----
> 
>   projectmanagers/cmake/testing/ctestrunjob.cpp bfff9ca 
> 
> Diff: https://git.reviewboard.kde.org/r/118497/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Pepe Osca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140603/fae6d41f/attachment.html>