Review Request 118460: Pimpl-ed, renamed and exported ImportMetadataWidget to DvcsImportMetadataWidget

Aleix Pol Gonzalez aleixpol at kde.org
Sun Jun 1 23:21:01 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118460/#review58915
-----------------------------------------------------------

Ship it!


Do you have a KDE account?

- Aleix Pol Gonzalez


On June 1, 2014, 10:15 p.m., Maciej Poleski wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118460/
> -----------------------------------------------------------
> 
> (Updated June 1, 2014, 10:15 p.m.)
> 
> 
> Review request for KDevelop.
> 
> 
> Repository: kdevplatform
> 
> 
> Description
> -------
> 
> ImportMetadataWidget is pimpl-ed, renamed to DvcsImportMetadataWidget and exported for (near) future use in new VCS plugin.
> 
> 
> Diffs
> -----
> 
>   vcs/CMakeLists.txt 11fe7e6 
>   vcs/dvcs/dvcsplugin.cpp 050831d 
>   vcs/dvcs/ui/dvcsimportmetadatawidget.h PRE-CREATION 
>   vcs/dvcs/ui/dvcsimportmetadatawidget.cpp PRE-CREATION 
>   vcs/dvcs/ui/dvcsimportmetadatawidget.ui PRE-CREATION 
>   vcs/dvcs/ui/importmetadatawidget.h f9bae22 
>   vcs/dvcs/ui/importmetadatawidget.cpp b63ad8f 
>   vcs/dvcs/ui/importmetadatawidget.ui a162f8a 
> 
> Diff: https://git.reviewboard.kde.org/r/118460/diff/
> 
> 
> Testing
> -------
> 
> Compiled
> UI seems working (tested by hand)
> 
> 
> Thanks,
> 
> Maciej Poleski
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kdevelop-devel/attachments/20140601/a7963c07/attachment.html>


More information about the KDevelop-devel mailing list